Run tidy on tests #12055
Merged
Run tidy on tests #12055
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
Merging failed, so I rebased onto master. r? @brson |
bors
added a commit
that referenced
this pull request
Feb 7, 2014
This PR extends the tidy formatting check to rust files in the test folder. To facilitate this, a few flags were added to tidy: * `xfail-tidy-cr` - Disables the check for CR characters for all following lines in the file * `xfail-tidy-tab` - Disables the check for tab characters for all following lines in the file * `xfail-tidy-linelength` - Disables the line length check for all following lines in the file Checks should not have to be disabled often. I disabled line length checks in `debug-info` tests that use `debugger:` checks, but aside from that, there were relatively few exclusions. Running tidy on all the tests does slow down the formatting check, so it may be worth investigating further optimization. cc #4534
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR extends the tidy formatting check to rust files in the test folder. To facilitate this, a few flags were added to tidy:
xfail-tidy-cr- Disables the check for CR characters for all following lines in the filexfail-tidy-tab- Disables the check for tab characters for all following lines in the filexfail-tidy-linelength- Disables the line length check for all following lines in the fileChecks should not have to be disabled often. I disabled line length checks in
debug-infotests that usedebugger:checks, but aside from that, there were relatively few exclusions. Running tidy on all the tests does slow down the formatting check, so it may be worth investigating further optimization.cc #4534